Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

resolve issue #110 #111

Merged
merged 1 commit into from
Dec 19, 2024
Merged

resolve issue #110 #111

merged 1 commit into from
Dec 19, 2024

Conversation

nurzhan-saktaganov
Copy link
Collaborator

@nurzhan-saktaganov nurzhan-saktaganov commented Dec 12, 2024 •
edited
Loading

What has been done? Why? What problem is being solved?

I didn't forget about (remove if it is not applicable):

Related issues:

@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_110 branch 4 times, most recently from 30eaecf to 1bb6d11 Compare December 12, 2024 20:40
@nurzhan-saktaganov nurzhan-saktaganov linked an issue Dec 12, 2024 that may be closed by this pull request
A new interface instead of RouterCallImpl #110
Closed
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.02521% with 44 lines in your changes missing coverage. Please review.

Project coverage is 66.12%. Comparing base (be1cfc4) to head (f2d96c5).

Files with missing lines Patch % Lines
api.go 62.06% 41 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   66.71%   66.12%   -0.60%     
==========================================
  Files          13       13              
  Lines        1391     1464      +73     
==========================================
+ Hits          928      968      +40     
- Misses        394      425      +31     
- Partials       69       71       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_110 branch 2 times, most recently from 7bfaa62 to 45763c4 Compare December 12, 2024 22:03
@nurzhan-saktaganov nurzhan-saktaganov changed the title Nsaktaganov resolve issue 110 resolve issue #110 Dec 12, 2024
@nurzhan-saktaganov
Copy link
Collaborator Author

nurzhan-saktaganov commented Dec 12, 2024 •
edited
Loading 

n.saktaganov@n-saktaganov tnt % make bench
go test -bench=. -benchmem -cpuprofile profile_cpu.out
goos: darwin
goarch: arm64
pkg: github.com/KaymeKaydex/go-vshard-router/tests/tnt
cpu: Apple M3 Pro
BenchmarkCallSimpleInsert_GO_RouterCallOld-12              11652             94190 ns/op            1504 B/op         30 allocs/op
BenchmarkCallSimpleInsert_GO_RouterCall-12                 13240             92953 ns/op            1958 B/op         37 allocs/op
BenchmarkCallSimpleInsert_GO_Call-12                       12860             91826 ns/op            1822 B/op         33 allocs/op
BenchmarkCallSimpleInsert_Lua-12                            8499            135856 ns/op            1185 B/op         19 allocs/op

BenchmarkCallSimpleSelect_GO_RouterCallOld-12              14445             82350 ns/op            2757 B/op         54 allocs/op
BenchmarkCallSimpleSelect_GO_RouterCall-12                 16130             76471 ns/op            2699 B/op         53 allocs/op
BenchmarkCallSimpleSelect_GO_Call-12                       15856             75416 ns/op            2146 B/op         41 allocs/op
BenchmarkCallSimpleSelect_Lua-12                            9272            119348 ns/op            1287 B/op         21 allocs/op
PASS
ok      github.com/KaymeKaydex/go-vshard-router/tests/tnt       30.851s

@nurzhan-saktaganov nurzhan-saktaganov linked an issue Dec 12, 2024 that may be closed by this pull request
refactor the vshard mode instructions, and settings to indicate to the pool what to use #12
Closed
nurzhan-saktaganov
nurzhan-saktaganov commented Dec 13, 2024
View reviewed changes
api.go Outdated Show resolved Hide resolved
api.go Show resolved Hide resolved
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_110 branch from 93233dc to a3d1c2f Compare December 13, 2024 23:54
@KaymeKaydex
Copy link
Owner

looks very cool, as discussed we will fix the standard implementation of RouterCallImpl, although it is not optimal, since it decodes empty interfaces. Standard Call will allow to fix this. And also the next pr we will fix the sugar resolution and make it optimal

@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_110 branch 3 times, most recently from 5ff2a00 to 1f0bed5 Compare December 18, 2024 21:51
KaymeKaydex
KaymeKaydex suggested changes Dec 19, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
api.go Show resolved Hide resolved
api.go Outdated Show resolved Hide resolved
replicaset.go Outdated Show resolved Hide resolved
@nurzhan-saktaganov
resolve issue #110
f2d96c5 
* new methods 'Router.Call[XYZ]' to replace the deprecated one 'RouterCallImpl'
* new backward-compatible signature for StorageResultTypedFunc to fix interface for RouterCallImpl
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_110 branch from 1f0bed5 to f2d96c5 Compare December 19, 2024 09:19
@nurzhan-saktaganov nurzhan-saktaganov mentioned this pull request Dec 19, 2024
Open
@KaymeKaydex KaymeKaydex merged commit 84f7c54 into master Dec 19, 2024
8 checks passed
@nurzhan-saktaganov nurzhan-saktaganov deleted the nsaktaganov_resolve_issue_110 branch December 19, 2024 14:34
@nurzhan-saktaganov nurzhan-saktaganov mentioned this pull request Jan 9, 2025
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KaymeKaydex KaymeKaydex KaymeKaydex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nurzhan-saktaganov @codecov-commenter @KaymeKaydex